Skip to content

Commit fc0ba90

Browse files
committed
Build also for Poplar SDK v3.3
1 parent 14a1f59 commit fc0ba90

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/workflows/build_libpoplar.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ jobs:
1818
matrix:
1919
include:
2020
- docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314
21+
artifact_name: poplar-3.2.0
22+
- docker_image: graphcore/poplar:3.3.0-ubuntu-20.04-20230703
23+
artifact_name: poplar-3.3.0
2124
steps:
2225
- name: "Install, g++, jq"
2326
# g++ is needed to build the wrapper, jq for
@@ -32,6 +35,19 @@ jobs:
3235
with:
3336
version: "1.7"
3437
- uses: julia-actions/cache@v1
38+
- name: "Export environment variables"
39+
# Starting from graphcore/poplar:3.3.0 some environment variables like `CPATH` and
40+
# `LD_LIBRARY_PATH`, which we need for building the bindings, are only set with the
41+
# `bash` shell, while GHA uses by default `sh` for steps inside containers. So we
42+
# need to start a step with `shell: bash` and re-export the relevant variables for
43+
# the following steps.
44+
shell: bash
45+
run: |
46+
echo "PATH=${PATH}" >> "${GITHUB_ENV}"
47+
echo "CPATH=${CPATH}" >> "${GITHUB_ENV}"
48+
echo "LIBRARY_PATH=${LIBRARY_PATH}" >> "${GITHUB_ENV}"
49+
echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> "${GITHUB_ENV}"
50+
echo "POPLAR_SDK_ENABLED=${POPLAR_SDK_ENABLED}" >> "${GITHUB_ENV}"
3551
- name: Instantiate wrapper generation environment
3652
working-directory: ${{ github.workspace }}/deps
3753
run: |
@@ -54,5 +70,5 @@ jobs:
5470
julia --project=. --color=yes build_tarballs.jl --verbose
5571
- uses: actions/upload-artifact@v4
5672
with:
57-
name: products
73+
name: products-${{ matrix.artifact_name }}
5874
path: ${{ github.workspace }}/deps/bb_recipe/products

deps/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
77
libcxxwrap_julia_jll = "3eaa8342-bff7-56a5-9981-c04077f7cee7"
88

99
[compat]
10-
Clang = "0.14, 0.17.4"
10+
Clang = "0.14, 0.17.4, 0.18"
1111
JSON = "0.21.4"
1212
Pkg = "1"
1313
Scratch = "1.1"

0 commit comments

Comments
 (0)