Merge pull request #25 from artursreiljans/master

Fix PHP 8.4 deprecations (implicitly nullable arguments). Add PHP 8.4 to CI workflow.

Author: stof

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
             - uses: shivammathur/setup-php@v2
               with:
                   coverage: none
-                  php-version: '8.3'
+                  php-version: '8.4'
             - run: composer validate --strict --no-check-lock
 
     static_analysis:
@@ -25,7 +25,7 @@ jobs:
             - uses: shivammathur/setup-php@v2
               with:
                   coverage: none
-                  php-version: '8.3'
+                  php-version: '8.4'
             - name: Install dependencies
               run: composer update --ansi --no-progress --prefer-dist --no-interaction
             - run: vendor/bin/phpstan analyze
@@ -37,12 +37,12 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php: [ '7.4', '8.0', '8.1', '8.2', '8.3' ]
+                php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
                 min_stability: [ '' ]
                 name_suffix: [ '' ]
                 composer_flags: [ '' ]
                 include:
-                    - php: '8.3'
+                    - php: '8.4'
                       min_stability: 'dev'
                       name_suffix: ' (dev deps)'
                     - php: '7.4'

src/Asset/HashingVersionStrategy.php

@@ -10,7 +10,7 @@ class HashingVersionStrategy implements VersionStrategyInterface
     private AssetHasherInterface $hasher;
     private string $format;
 
-    public function __construct(AssetHasherInterface $hasher, string $format = null)
+    public function __construct(AssetHasherInterface $hasher, ?string $format = null)
     {
         $this->format = $format ?: '%s?%s';
         $this->hasher = $hasher;

src/CacheWarmer/HashCacheWarmer.php

@@ -36,7 +36,7 @@ public function __construct(AssetFinder $assetFinder, string $cacheFile, AssetHa
      *
      * @return string[]
      */
-    public function warmUp($cacheDir, string $buildDir = null): array
+    public function warmUp($cacheDir, ?string $buildDir = null): array
     {
         $phpArrayPool = new PhpArrayAdapter($this->cacheFile, $this->fallbackPool);
         $arrayPool = new ArrayAdapter(0, false);