refactor: enhance error handling in document store interactions

Author: ahmedrowaihi

packages/components/nodes/agentflow/Agent/Agent.ts

@@ -19,7 +19,7 @@ import { Tool } from '@langchain/core/tools'
 import { ARTIFACTS_PREFIX, SOURCE_DOCUMENTS_PREFIX, TOOL_ARGS_PREFIX } from '../../../src/agents'
 import { flatten } from 'lodash'
 import zodToJsonSchema from 'zod-to-json-schema'
-import { getErrorMessage } from '../../../src/error'
+import { DocumentStoreError, getErrorMessage } from '../../../src/error'
 import { DataSource } from 'typeorm'
 import {
     getPastChatHistoryImageMessages,
@@ -28,7 +28,6 @@ import {
     replaceBase64ImagesWithFileReferences,
     updateFlowState
 } from '../utils'
-import { DocumentStoreError } from '../../../src/error'
 
 interface ITool {
     agentSelectedTool: string
@@ -610,7 +609,10 @@ class Agent_Agentflow implements INode {
                         })
                     } catch (error) {
                         if (error instanceof DocumentStoreError) {
-                            console.warn(`Failed to initialize document store ${knowledgeBase.documentStore}, skipping:`, error.message)
+                            console.warn(
+                                `Failed to initialize document store ${knowledgeBase.documentStore}, skipping:`,
+                                getErrorMessage(error)
+                            )
                             continue
                         }
                         throw error

packages/components/nodes/tools/RetrieverTool/RetrieverTool.ts

@@ -7,6 +7,7 @@ import { getBaseClasses, resolveFlowObjValue } from '../../../src/utils'
 import { SOURCE_DOCUMENTS_PREFIX } from '../../../src/agents'
 import { RunnableConfig } from '@langchain/core/runnables'
 import { VectorStoreRetriever } from '@langchain/core/vectorstores'
+import { getErrorMessage } from '../../../src/error'
 
 const howToUse = `Add additional filters to vector store. You can also filter with flow config, including the current "state":
 - \`$flow.sessionId\`
@@ -209,13 +210,12 @@ class Retriever_Tools implements INode {
                 const sourceDocuments = JSON.stringify(docs)
                 return returnSourceDocuments ? content + SOURCE_DOCUMENTS_PREFIX + sourceDocuments : content
             } catch (error) {
+                const errorMessage = getErrorMessage(error)
                 const isDocStoreError =
-                    error.message &&
-                    (error.message.includes('document store') ||
-                        error.message.includes('vector store') ||
-                        error.message.includes('retriever'))
+                    errorMessage &&
+                    (errorMessage.includes('document store') || errorMessage.includes('vector store') || errorMessage.includes('retriever'))
                 if (isDocStoreError) {
-                    console.warn('Document store retrieval failed, returning fallback response:', error.message)
+                    console.warn('Document store retrieval failed, returning fallback response:', getErrorMessage(error))
                     return 'Knowledge base temporarily unavailable. Proceeding with general knowledge.'
                 }
                 throw error

packages/components/nodes/vectorstores/DocumentStoreVS/DocStoreVector.ts

@@ -1,6 +1,6 @@
 import { ICommonObject, IDatabaseEntity, INode, INodeData, INodeOptionsValue, INodeOutputsValue, INodeParams } from '../../../src/Interface'
 import { DataSource } from 'typeorm'
-import { DocumentStoreError } from '../../../src/error'
+import { DocumentStoreError, getErrorMessage } from '../../../src/error'
 
 class DocStore_VectorStores implements INode {
     label: string
@@ -118,7 +118,7 @@ class DocStore_VectorStores implements INode {
             if (error instanceof DocumentStoreError) {
                 throw error
             }
-            throw new DocumentStoreError(error.message, nodeData.inputs?.selectedStore)
+            throw new DocumentStoreError(getErrorMessage(error), nodeData.inputs?.selectedStore)
         }
     }
 }

packages/server/src/utils/buildAgentflow.ts

@@ -1229,7 +1229,7 @@ const executeNode = async ({
             getErrorMessage(error).includes('Knowledge base temporarily unavailable')
 
         if (isDocStoreError && !isAborted) {
-            console.warn(`Document store error in node ${nodeId}, continuing execution:`, getErrorMessage(error))
+            logger.warn(`Document store error in node ${nodeId}, continuing execution:`, getErrorMessage(error))
             agentFlowExecutedData.push({
                 nodeId,
                 nodeLabel: reactFlowNode.data.label,
@@ -1802,7 +1802,7 @@ export const executeAgentFlow = async ({
                 getErrorMessage(error).includes('Knowledge base temporarily unavailable')
             // Handle document store errors more gracefully
             if (isDocStoreError && !isAborted) {
-                console.warn(`Document store error in node ${currentNode.nodeId}, continuing execution:`, getErrorMessage(error))
+                logger.warn(`Document store error in node ${currentNode.nodeId}, continuing execution:`, getErrorMessage(error))
                 // Add warning to execution data instead of error
                 agentFlowExecutedData.push({
                     nodeId: currentNode.nodeId,