Refactor packet hooks to use composition over inheritance #206
+101
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not fully work as intended. Marking as draft until completion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request ensures LimboAPI can still function with Velocity-CTD. As of a few days ago, I refactored (most) of CTD's code. Most core changes involved implementing finals in pretty much every location Google/Sun checks instructed me to. This resulted in LimboAPI throwing an injection error in three different places. Instead of modifying CTD's logic, I felt it'd be better to utilize composition > inheritances since it better reflects code changes that (could also) be made in regular Velocity, conditionally. I do not anticipate that this pull request is perfect; instead, it is a best-effort attempt.
Attached issue: GemstoneGG/Velocity-CTD#587