Skip to content

Commit 6998019

Browse files
authored
fix: remove early return when errors occur during parallel deploy (#1107)
fix: remove early return when errors occur during prallel deploy Since, all of the go-routines are already started, and cannot be canceled caching the errors and return early does not make much sense.
1 parent f590029 commit 6998019

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

pkg/deploy/deploy.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,6 @@ func deployComponentsParallel(ctx context.Context, components []graph.SortedComp
199199
// Collect errors from goroutines and append to the 'errs' slice.
200200
for range components {
201201
componentDeployErrs := <-errChan
202-
if len(componentDeployErrs) > 0 && !opts.ContinueOnErr && !opts.DryRun {
203-
return componentDeployErrs
204-
}
205202
errs = append(errs, componentDeployErrs...)
206203
}
207204

0 commit comments

Comments
 (0)