calculate normal if not present

YasInvolved · YasInvolved · commit 5eef9a99b0fc · 2025-07-31T16:46:28.000+02:00
diff --git a/src/nbl/asset/interchange/CSTLMeshFileLoader.cpp b/src/nbl/asset/interchange/CSTLMeshFileLoader.cpp
@@ -282,9 +282,13 @@ SAssetBundle CSTLMeshFileLoader::loadAsset(system::IFile* _file, const IAssetLoa
 
 		if (context.normals.back() == hlsl::float32_t3{})
 		{
-			// TODO: calculate normals
-			assert(false);
+			auto& p1 = *(context.vertices.rbegin() + 2);
+			auto& p2 = *(context.vertices.rbegin() + 1);
+			auto& p3 = *(context.vertices.rbegin() + 0);
 
+			auto u = p2 - p1;
+			auto v = p3 - p1;
+			context.normals.emplace_back(hlsl::normalize(hlsl::cross(u, v)));
 		}
 	} // end while (_file->getPos() < filesize)
 

Original file line number	Diff line number	Diff line change
`@@ -282,9 +282,13 @@ SAssetBundle CSTLMeshFileLoader::loadAsset(system::IFile* _file, const IAssetLoa`
`282`	`282`
`283`	`283`	`if (context.normals.back() == hlsl::float32_t3{})`
`284`	`284`	`{`
`285`		`- // TODO: calculate normals`
`286`		`- assert(false);`
	`285`	`+ auto& p1 = *(context.vertices.rbegin() + 2);`
	`286`	`+ auto& p2 = *(context.vertices.rbegin() + 1);`
	`287`	`+ auto& p3 = *(context.vertices.rbegin() + 0);`
`287`	`288`
	`289`	`+ auto u = p2 - p1;`
	`290`	`+ auto v = p3 - p1;`
	`291`	`+ context.normals.emplace_back(hlsl::normalize(hlsl::cross(u, v)));`
`288`	`292`	`}`
`289`	`293`	`} // end while (_file->getPos() < filesize)`
`290`	`294`