clean code

Author: AlphaBs

CmlLib/Core/Auth/MLogin.cs

@@ -313,7 +313,7 @@ public bool Signout(string id, string pw)
         }
     }
 
-    public static class HttpWebResponseExt
+    internal static class HttpWebResponseExt
     {
         public static HttpWebResponse GetResponseNoException(this HttpWebRequest req)
         {

CmlLib/Utils/Changelogs.cs

@@ -28,7 +28,7 @@ public static async Task<Changelogs> GetChangelogs()
             }
 
             var obj = JObject.Parse(response);
-            var versions = new Dictionary<string, string?>();
+            var versionDict = new Dictionary<string, string?>();
             var array = obj["entries"] as JArray;
             if (array != null)
             {
@@ -39,11 +39,11 @@ public static async Task<Changelogs> GetChangelogs()
                         continue;
 
                     var body = item["body"]?.ToString();
-                    versions[version] = body;
+                    versionDict[version] = body;
                 }
             }
 
-            return new Changelogs(versions);
+            return new Changelogs(versionDict);
         }
 
         private Changelogs(Dictionary<string, string?> versions)

CmlLib/Utils/IOUtil.cs

@@ -206,14 +206,15 @@ public static async Task CopyFileAsync(string sourceFile, string destinationFile
             var destinationStream = AsyncWriteStream(destinationFile, false);
 
             await sourceStream.CopyToAsync(destinationStream).ConfigureAwait(false);
-            await destinationStream.FlushAsync();
+            await destinationStream.FlushAsync().ConfigureAwait(false);
 
             await disposeStreamAsync(sourceStream).ConfigureAwait(false);
             await disposeStreamAsync(destinationStream).ConfigureAwait(false);
         }
 
         private static Task disposeStreamAsync(Stream stream)
         {
+            // .NET Framework does not support DisposeAsync
 #if NETFRAMEWORK
             stream.Dispose();
             return Task.CompletedTask;

CmlLib/Utils/NativeMethods.cs

@@ -4,7 +4,7 @@
 
 namespace CmlLib.Utils
 {
-    static class NativeMethods
+    internal static class NativeMethods
     {
         [DllImport("libc", SetLastError = true)]
         private static extern int chmod(string pathname, int mode);

CmlLib/Utils/SevenZipWrapper.cs

@@ -13,11 +13,18 @@ public static void DecompressFileLZMA(string inFile, string outFile)
 
             // Read the decoder properties
             byte[] properties = new byte[5];
-            input.Read(properties, 0, 5);
+            var readCount = input.Read(properties, 0, 5);
 
+            if (readCount < 5)
+                return;
+            
             // Read in the decompress file size.
             byte[] fileLengthBytes = new byte[8];
-            input.Read(fileLengthBytes, 0, 8);
+            readCount = input.Read(fileLengthBytes, 0, 8);
+
+            if (readCount < 8)
+                return;
+            
             long fileLength = BitConverter.ToInt64(fileLengthBytes, 0);
 
             coder.SetDecoderProperties(properties);

CmlLib/Utils/WebDownload.cs

@@ -7,7 +7,7 @@
 
 namespace CmlLib.Utils
 {
-    public class WebDownload
+    internal class WebDownload
     {
         public static bool IgnoreProxy { get; set; } = true;