fix(oracle): disabling global hidden internal timeout (#298)

* fix: try query command without reading rows

* fix: try setting maxLifeTime parameter

* fix: try setting maxIdleTime parameter

* fix: keep options on oracle-raw urls

* fix(oracle): disabling global hidden internal timeout

* test(oracle): fix failing test

Author: adrienaury

CHANGELOG.md

@@ -14,6 +14,10 @@ Types of changes
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+## [3.0.1]
+
+- `Fixed` hidden global internal timeout of 240s with Oracle driver is now disabled by default
+
 ## [3.0.0]
 
 - `Changed` table or column names were not correctly matched in terms of case sensitivity (lowercase or uppercase) in table.yaml

internal/app/urlbuilder/urlbuilder.go

@@ -66,18 +66,35 @@ func GenOracleRaw(u *dburl.URL) (string, string, error) {
 
 func genJDBCOracle(u *dburl.URL) (string, string, error) {
 	if u.User == nil {
-		return go_ora.BuildJDBC("", "", u.Host, map[string]string{}), "", nil
+		return go_ora.BuildJDBC("", "", u.Host, getOptions(u)), "", nil
 	}
 
 	if un := u.User.Username(); len(un) > 0 {
 		if up, ok := u.User.Password(); ok {
-			return go_ora.BuildJDBC(u.User.Username(), up, u.Host, map[string]string{}), "", nil
+			return go_ora.BuildJDBC(u.User.Username(), up, u.Host, getOptions(u)), "", nil
 		} else {
-			return go_ora.BuildJDBC(u.User.Username(), "", u.Host, map[string]string{}), "", nil
+			return go_ora.BuildJDBC(u.User.Username(), "", u.Host, getOptions(u)), "", nil
 		}
 	}
 
-	return go_ora.BuildJDBC("", "", u.Host, map[string]string{}), "", nil
+	return go_ora.BuildJDBC("", "", u.Host, getOptions(u)), "", nil
+}
+
+func getOptions(u *dburl.URL) map[string]string {
+	values := u.Query()
+
+	options := make(map[string]string, len(values))
+
+	// fix: we want the global timeout to be disabled, like it is for every other drivers
+	options["TIMEOUT"] = "0"
+
+	for key, vals := range values {
+		if len(vals) > 0 {
+			options[key] = vals[len(vals)-1]
+		}
+	}
+
+	return options
 }
 
 func init() {

internal/app/urlbuilder/urlbuilder_test.go

@@ -1,6 +1,7 @@
 package urlbuilder
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -31,7 +32,7 @@ func TestBuildOracleURL(t *testing.T) {
 				t.Errorf("parse return error : %v", err)
 			}
 
-			assert.Equal(t, tt.want, url.DSN)
+			assert.Equal(t, tt.want, strings.ReplaceAll(strings.ReplaceAll(url.DSN, "TIMEOUT=0&", ""), "&TIMEOUT=0", ""))
 		})
 	}
 }