fix(http): inject filter in http controler (#370)

* fix(http): inject filter in http controler

* test(http): bad filter parameter

* test(http):  smaller id

Author: youen

CHANGELOG.md

@@ -14,6 +14,10 @@ Types of changes
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+## [3.2.1]
+
+ - `Fixed`Filter Parameter Not Working in "lino http" Command [#369](https://github.com/CGI-FR/LINO/issues/369)
+
 ## [3.2.0]
 
 - `Added` flag `log-sql` (short `l`) to the push command

internal/app/pull/http.go

@@ -36,7 +36,7 @@ func HandlerFactory(ingressDescriptor string) func(w http.ResponseWriter, r *htt
 			datasourceName string
 			ok             bool
 			distinct       bool
-			filter         map[string]string
+			filter         pull.Row
 			limit          uint
 			where          string
 		)
@@ -45,7 +45,7 @@ func HandlerFactory(ingressDescriptor string) func(w http.ResponseWriter, r *htt
 
 		query := r.URL.Query()
 
-		filter = map[string]string{}
+		filter = pull.Row{}
 
 		if query.Get("filter") != "" {
 			for _, f := range strings.Split(query.Get("filter"), ",") {
@@ -142,7 +142,7 @@ func HandlerFactory(ingressDescriptor string) func(w http.ResponseWriter, r *htt
 		pullExporter := pullExporterFactory(w)
 		puller := pull.NewPuller(plan, datasource, pullExporter, pull.NoTraceListener{})
 
-		e3 := puller.Pull(start, pull.Filter{Limit: limit, Values: pull.Row{}, Where: where, Distinct: distinct}, startSelect, nil, nil)
+		e3 := puller.Pull(start, pull.Filter{Limit: limit, Values: filter, Where: where, Distinct: distinct}, startSelect, nil, nil)
 		if e3 != nil {
 			log.Error().Err(e3).Msg("")
 			w.WriteHeader(http.StatusInternalServerError)

tests/suites/http/pull.yml

@@ -68,10 +68,19 @@ testcases:
     steps:
       - type: http
         method: GET
-        url: http://lino:8000/api/v1/data/source?filter=address_id:1
+        url: http://lino:8000/api/v1/data/source?filter=address_id:2
         assertions:
           - result.statuscode ShouldEqual 200
-          - result.bodyjson.address_id ShouldEqual 1
+          - result.bodyjson.address_id ShouldEqual 2
+
+  - name: pull filter empty
+    steps:
+      - type: http
+        method: GET
+        url: http://lino:8000/api/v1/data/source?filter=address_id:99
+        assertions:
+          - result.statuscode ShouldEqual 200
+          - result.body ShouldBeEmpty
 
   - name: pull filter multi values
     steps: