Skip to content

Missing test cases. #320

@rwjblue

Description

@rwjblue

I did a quick skim of our test coverage and noticed a few holes where we need some coverage:

  • bb.defer is untested (yes, it is deprecated, but it should still have a test given that it is public API)
  • Error conditions in bb.on and bb.off are not tested (passing no eventName, or passing no callback)
  • end called without begin error thrown in bb.end() is not tested
  • invoking bb.later() e.g. with no arguments. This should be an error IMHO, but currently just returns early
  • bb.ensureInstance() is public API that has no tests
  • bb.join(function() { }) (no target or args) when within a run-loop (e.g. when we are actually joining an existing loop) has no tests
  • bb.join(function() { }, someArg) (no target with args) when within a run-loop (e.g. when we are actually joining an existing loop) has no tests
  • } else { end = middle; } in binary-search has no tests
  • Queue.prototype.flush with a custom before / after has no tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions