-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Description
I did a quick skim of our test coverage and noticed a few holes where we need some coverage:
bb.defer
is untested (yes, it is deprecated, but it should still have a test given that it is public API)- Error conditions in
bb.on
andbb.off
are not tested (passing no eventName, or passing no callback) end called without begin
error thrown inbb.end()
is not tested- invoking
bb.later()
e.g. with no arguments. This should be an error IMHO, but currently just returns early bb.ensureInstance()
is public API that has no testsbb.join(function() { })
(no target or args) when within a run-loop (e.g. when we are actually joining an existing loop) has no testsbb.join(function() { }, someArg)
(no target with args) when within a run-loop (e.g. when we are actually joining an existing loop) has no tests} else { end = middle; }
inbinary-search
has no testsQueue.prototype.flush
with a custombefore
/after
has no tests
Metadata
Metadata
Assignees
Labels
No labels