Skip to content

Fix logging response from NMAgent in syncHostNCVersion function #3746

@thatmattlong

Description

@thatmattlong

In the syncHostNCVersion, if the number of updated NCs in the response from NMAgent does not match the expected number of updated NCs in CNS state, the function will log at the end:

if len(outdatedNCs) > 0 {
	return len(programmedNCs), errors.Errorf("unabled to update some NCs: %v, missing or bad response from NMA", outdatedNCs)
}

This is not a useful message because we don't know if the outdated NCs are programmed to some older version or if the NCs are completely missing from the response from NMAgent. This log line should be updated to separately print the missing NCs in the response and the outdated NCs in the response (including the expected and actual versions of the outdated NCs).

Metadata

Metadata

Assignees

Labels

cnsRelated to CNS.staleStale due to inactivity.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions