♻️ Reorg expire durations

Author: AlexV525

packages/agent_dart_base/lib/agent/agent/http/index.dart

@@ -39,8 +39,13 @@ Future<T> withRetry<T>(
   }
 }
 
+/// Most of the timeouts will happen in 5 minutes.
+const defaultExpireInMinutes = 5;
+const defaultExpireInDuration = Duration(minutes: defaultExpireInMinutes);
+
 /// Default delta for ingress expiry is 5 minutes.
-const _defaultIngressExpiryDeltaInMilliseconds = 5 * 60 * 1000;
+const _defaultIngressExpiryDeltaInMilliseconds =
+    defaultExpireInMinutes * 60 * 1000;
 
 /// Root public key for the IC, encoded as hex
 const _icRootKey = '308182301d060d2b0601040182dc7c0503010201060c2b0601040182dc7'

packages/agent_dart_base/lib/agent/polling/strategy.dart

@@ -19,7 +19,7 @@ PollStrategy defaultStrategy() {
   return chain([
     conditionalDelay(once(), 1000),
     backoff(1000, 1.2),
-    timeout(5 * 60 * 1000),
+    timeout(defaultExpireInDuration),
   ]);
 }
 
@@ -84,19 +84,19 @@ PollStrategy throttlePolling(int throttleMilliseconds) {
   };
 }
 
-PollStrategy timeout(int milliseconds) {
-  final end = DateTime.now().millisecondsSinceEpoch + milliseconds;
+PollStrategy timeout(Duration duration) {
+  final end = DateTime.now().add(duration);
   return (
     Principal canisterId,
     RequestId requestId,
     RequestStatusResponseStatus status,
   ) async {
-    if (DateTime.now().millisecondsSinceEpoch > end) {
+    if (DateTime.now().isAfter(end)) {
       throw TimeoutException(
-        'Request timed out after $milliseconds milliseconds:\n'
+        'Request timed out after $duration:\n'
         '  Request ID: ${requestIdToHex(requestId)}\n'
         '  Request status: $status\n',
-        Duration(milliseconds: milliseconds),
+        duration,
       );
     }
   };

packages/agent_dart_base/lib/identity/delegation.dart

@@ -164,9 +164,7 @@ class DelegationChain {
     DelegationChain? previous,
     List<Principal>? targets,
   }) async {
-    expiration ??= DateTime.fromMillisecondsSinceEpoch(
-      DateTime.now().millisecondsSinceEpoch + 15 * 60 * 1000,
-    );
+    expiration ??= DateTime.now().add(const Duration(minutes: 15));
     final delegation = await _createSingleDelegation(
       from,
       to,