Merge pull request #109 from ArcanaFramework/handle-union-in-from-mime

tclose · web-flow · commit b78ffbd542d1 · 2025-07-02T19:17:33.000+10:00
diff --git a/fileformats/core/datatype.py b/fileformats/core/datatype.py
@@ -263,7 +263,7 @@ def get_format(mime_name: str) -> ty.Type[DataType]:
                         f"Did not find '{class_name}' class in fileformats.{namespace} "
                         f"corresponding to MIME, or MIME-like, type {mime_string}"
                     ) from None
-        if not issubclass(klass, cls):
+        if not (ty.get_origin(klass) is ty.Union or issubclass(klass, cls)):
             raise FormatRecognitionError(
                 f"Class '{klass}' does not inherit from '{cls}'"
             )

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ def get_format(mime_name: str) -> ty.Type[DataType]:`
`263`	`263`	`f"Did not find '{class_name}' class in fileformats.{namespace} "`
`264`	`264`	`f"corresponding to MIME, or MIME-like, type {mime_string}"`
`265`	`265`	`) from None`
`266`		`- if not issubclass(klass, cls):`
	`266`	`+ if not (ty.get_origin(klass) is ty.Union or issubclass(klass, cls)):`
`267`	`267`	`raise FormatRecognitionError(`
`268`	`268`	`f"Class '{klass}' does not inherit from '{cls}'"`
`269`	`269`	`)`