Skip to content

Commit 6a91d59

Browse files
committed
disabled unneeded xfails
1 parent d817705 commit 6a91d59

File tree

3 files changed

+25
-25
lines changed

3 files changed

+25
-25
lines changed

extras/fileformats/extras/application/tests/test_application_serialization.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import sys
2-
import pytest
1+
# import sys
2+
# import pytest
33
from fileformats.application import Json, Yaml
44

55

@@ -28,10 +28,10 @@
2828
"""
2929

3030

31-
@pytest.mark.xfail(
32-
sys.version_info.minor <= 9,
33-
reason="upstream Pydra issue with type-checking 'type' objects",
34-
)
31+
# @pytest.mark.xfail(
32+
# sys.version_info.minor <= 9,
33+
# reason="upstream Pydra issue with type-checking 'type' objects",
34+
# )
3535
def test_json_to_yaml(work_dir):
3636
in_file = work_dir / "test.json"
3737
with open(in_file, "w") as f:
@@ -41,10 +41,10 @@ def test_json_to_yaml(work_dir):
4141
assert yml.contents == SAMPLE_YAML
4242

4343

44-
@pytest.mark.xfail(
45-
sys.version_info.minor <= 9,
46-
reason="upstream Pydra issue with type-checking 'type' objects",
47-
)
44+
# @pytest.mark.xfail(
45+
# sys.version_info.minor <= 9,
46+
# reason="upstream Pydra issue with type-checking 'type' objects",
47+
# )
4848
def test_yaml_to_json(work_dir):
4949
in_file = work_dir / "test.yaml"
5050
with open(in_file, "w") as f:
Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import sys
1+
# import sys
22
import pytest
33
from imageio.core.fetching import get_remote_file
44
from fileformats.image import Bitmap, Gif, Jpeg, Png, Tiff
@@ -15,25 +15,25 @@ def png() -> Png:
1515
return Png(get_remote_file("images/chelsea.png"))
1616

1717

18-
@pytest.mark.xfail(
19-
sys.version_info.minor <= 9,
20-
reason="upstream Pydra issue with type-checking 'type' objects",
21-
)
18+
# @pytest.mark.xfail(
19+
# sys.version_info.minor <= 9,
20+
# reason="upstream Pydra issue with type-checking 'type' objects",
21+
# )
2222
def test_jpg_to_gif(jpg):
2323
Gif.convert(jpg)
2424

2525

26-
@pytest.mark.xfail(
27-
sys.version_info.minor <= 9,
28-
reason="upstream Pydra issue with type-checking 'type' objects",
29-
)
26+
# @pytest.mark.xfail(
27+
# sys.version_info.minor <= 9,
28+
# reason="upstream Pydra issue with type-checking 'type' objects",
29+
# )
3030
def test_png_to_tiff(png):
3131
Tiff.convert(png)
3232

3333

34-
@pytest.mark.xfail(
35-
sys.version_info.minor <= 9,
36-
reason="upstream Pydra issue with type-checking 'type' objects",
37-
)
34+
# @pytest.mark.xfail(
35+
# sys.version_info.minor <= 9,
36+
# reason="upstream Pydra issue with type-checking 'type' objects",
37+
# )
3838
def test_png_to_bitmap(png):
3939
Bitmap.convert(png)

fileformats/generic/tests/test_file.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22
from fileformats.generic import FsObject, File
3-
from fileformats.testing import Magic, Foo, MyFormatX
3+
from fileformats.testing import Magic, MagicVersion, Foo, MyFormatX
44

55

66
def test_sample_fsobject():
@@ -27,4 +27,4 @@ def test_sample_magic():
2727
reason="generate_sample_data for WithMagicVersion file types is not implemented yet"
2828
)
2929
def test_sample_magic_version():
30-
assert isinstance(Magic.sample(), Magic)
30+
assert isinstance(MagicVersion.sample(), MagicVersion)

0 commit comments

Comments
 (0)