Skip to content

Refactoring issues  #1

@mohd4cs

Description

@mohd4cs

Hi AbdullahObaid,
Thanks for your great job!

If you allow me I have a question in Http/Middleware/ArabicNumbersMiddleware.php

   protected function processValue($value, $key)
   {
   if (is_string($value)) {
   $arabic_eastern = array('٠', '١', '٢', '٣', '٤', '٥', '٦', '٧', '٨', '٩');
   $arabic_western = array('0', '1', '2', '3', '4', '5', '6', '7', '8', '9');
   return str_replace($arabic_eastern, $arabic_western, $value);
  }
   return $value;
   }

My questio is that:
Why did you pass $key pram even you don't use it inside the processValue function??

Finally, if you have tested your package it will be much better for us to use this amazing package to solve Arabic Numbers problem.

Best regards M. Saud 🤠

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions