Skip to content

Commit 6b88ec4

Browse files
rwalton-armPatater
authored andcommitted
ci: Remove licenseheaders pre-commit check
The `licenseheaders` tool has a number of issues which make it unsuitable for our CI: - It's not smart enough to know when it should apply a single year or a year range to touched files. No combination of options or templates can handle this. - If a license header contains multiple contributor lines and year ranges, they are blindly overwritten with the license template. It's impossible to create a template to handle this. - It can't be ran on all files because it will try to update all existing files whether they've actually been changed or not.
1 parent ca0fc81 commit 6b88ec4

File tree

3 files changed

+0
-25
lines changed

3 files changed

+0
-25
lines changed

.pre-commit-config.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
11
repos:
2-
- repo: https://github.com/kdeyev/licenseheaders.git
3-
rev: 'master'
4-
hooks:
5-
- id: licenseheaders
6-
exclude: \.yaml$|\.yml$
7-
args: ["-s", "ci_scripts/licenseheaders.json", "-t",
8-
"ci_scripts/templates/.copyright.tmpl", "-cy", "-f"]
9-
102
- repo: https://github.com/psf/black
113
rev: 19.10b0
124
hooks:

ci_scripts/licenseheaders.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

ci_scripts/templates/.copyright.tmpl

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)